In software, the best practice is to review each other's code.
Careless mistake
This is an honest mistake on the part of the individual.
As reviewer, you should be there to test it. To gauge the level of communication and test it.
Well-written code also means well-tested code. If careless mistakes slip through despite testing, it means your tests are likely inadequate. It means that your tests do not adequately cover exactly what you want the software to do.
Lack of Tests
Others will not know what to expect when they use, run your code.
Or worse, they think they know, but you know, there are always those cases on the margins that will stump you up.
Style Problem
The purpose of style is to communicate one's ideas better. If there are style problems, there is a problem in communication.
This could be unaligned style - that the team does not have consensus regarding communication standard, or not having a tool to automate style checking.
Not following Design Patterns or Non-Idiomatic Code
"I did it my way"
When you are developing a product, it's not directly about you. It's not that you are secondary in a hierarchical sense, it means you try to do the best for the product.
When one does not follow conventions, or invents a new one without telling anyone, it imposes an additional cost on others to understand it.
No comments:
Post a Comment